remove $self = $this; use ($self) in 5.4 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ($instance instanceof ServiceLocatorAwareInterface) { | ||
| $instance->setServiceLocator($self); | ||
| $instance->setServiceLocator($this); |
There was a problem hiding this comment.
it makes test error,
1) ZendTest\ServiceManager\AbstractPluginManagerTest::testValidatePluginIsCalledWithDelegatorFactoryIfItsAService
Undefined variable: serviceManager
maybe rollback it ?
There was a problem hiding this comment.
oh, its strange, seems not related with it...
| @@ -605,12 +605,10 @@ public function create($name) | |||
| */ | |||
| private function createDelegatorCallback($delegatorFactory, $rName, $cName, $creationCallback) | |||
| { | |||
| $serviceManager = $this; | |||
There was a problem hiding this comment.
Careful with the delegators: they're messy ;-)
There was a problem hiding this comment.
I made a rollback change on samsonasik@68a626a , and in my local the test is pass now.
|
@Ocramius yay, travis is green now ;) |
|
@samsonasik merging, thanks! |
Ocramius
added a commit
that referenced
this pull request
Jan 14, 2015
remove $self = $this; use ($self) in 5.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @carnage I created a PR for your suggestion.