Updates to compile cleanly on ROS 2 Rolling on Ubuntu 24.04 #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer CMake complains about anything older than that, and CMake 3.5 was released in 2016. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Calling message("mystring") in CMake, by default,
outputs to stderr. Since these are generally informational
messages, change this to message(STATUS "mystring"), which
prints to stdout instead. This should quite down warnings
when building with colcon (and on the ROS 2 buildfarm).
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Newer versions of CMake have changed how finding OpenGL works. If you don't specify anything at all, they will complain that you haven't told them how to find OpenGL. Work around this by explicitly setting OpenGL_GL_PREFERENCE to LEGACY, which tells CMake how you want to find OpenGL. This quiets the warning. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Apparently modern Qt has deprecated using an integer to initialize Qt::Flags objects. Instead, use the default constructor which should do the same thing. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Closed
|
Thanks for your contribution! |
c-andy-martin
pushed a commit
to BadgerTechnologies/octomap
that referenced
this pull request
May 31, 2024
) * Update minimum to CMake 3.5. Newer CMake complains about anything older than that, and CMake 3.5 was released in 2016. Signed-off-by: Chris Lalancette <clalancette@gmail.com> * Cleanup stderr output from CMake. Calling message("mystring") in CMake, by default, outputs to stderr. Since these are generally informational messages, change this to message(STATUS "mystring"), which prints to stdout instead. This should quite down warnings when building with colcon (and on the ROS 2 buildfarm). Signed-off-by: Chris Lalancette <clalancette@gmail.com> * Add in a variable to control how OpenGL is found. Newer versions of CMake have changed how finding OpenGL works. If you don't specify anything at all, they will complain that you haven't told them how to find OpenGL. Work around this by explicitly setting OpenGL_GL_PREFERENCE to LEGACY, which tells CMake how you want to find OpenGL. This quiets the warning. Signed-off-by: Chris Lalancette <clalancette@gmail.com> * Switch away from 0 for Qt::WindowFlags. Apparently modern Qt has deprecated using an integer to initialize Qt::Flags objects. Instead, use the default constructor which should do the same thing. Signed-off-by: Chris Lalancette <clalancette@gmail.com> --------- Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is more information in the individual commits, but this PR makes it so that octomap compiles warning-free on Ubuntu 24.04. While none of this is actually required to make it work there, it is a much nicer experience for users when there aren't tons of warnings.
Let me know if you'd like me to split this up into individual PRs, and I can do that.