Rewrite M18/M84 as they cause the printer to crash too.

[Azelphur]

Hi, obligatory I have no idea what I'm doing.

I have been helping a fellow that has a Tronxy XY-2 Pro that is running the dreaded CBD firmware, this plugin mostly fixed it for him, however he found that at the end of every print, octoprint would loose connection to the printer, saying that the printer keeps requesting line X again and again, communication stuck.

After some investigation, he discovered that M84 was the issue. We hopped into the Octoprint console and ran M84 X Y E and the connection dropped. We also tried M84 X, M84 Y, M84 E, M18 X Y E and they all caused the connection to drop too. As such I think the only solution is truncating all M84 and M18 calls, which is what I have done in this patch. He has tested the patch and confirmed that it has resolved the issue for him.

[foosel]

Thanks. This firmware really is a bloody nightmare.

Before I merge this, could you ask your friend if M84 X0 works? That firmware seems to have issue with standalone axes names for G28, so before we strip axes parameters altogether from M18 and M84 I'd like to make sure it really doesn't support them instead of maybe just using the same broken parser used for G28.

[foosel]

Does this push mean you tested that and M18/M84 work on that firmware with the 0 added axes identifiers, or is this just a "let's wait and see" push? 🤔

[Azelphur]

My friend tested M84 X0 and it did not crash the printer, I pushed to git so he could test the plugin. Just waiting for him to do that. Once he has tested the plugin I'll report back, or if you think it's fine you can just accept the PR :)

[foosel]

Oh, I'll just wait until you've got a confirmation back, better safe than sorry with this firmware ;)

[Azelphur]

Friend has tested and confirms it works :)