Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Abandoned Plugin] Filament Sensor Simplified #1148

Open
valemaio2 opened this issue Jan 19, 2023 · 11 comments
Open

[Abandoned Plugin] Filament Sensor Simplified #1148

valemaio2 opened this issue Jan 19, 2023 · 11 comments

Comments

@valemaio2
Copy link

Which Plugin?

https://plugins.octoprint.org/plugins/filamentsensorsimplified/

Link to ticket on plugin's issue tracker confirming abandonment

LuckyX182/Filament_sensor_simplified#71

Is there someone open to adopting it?

@valemaio2

@valemaio2
Copy link
Author

I know the issue asking if the plugin has been abandoned has been opened for only five days, but there are other issues with the plugin opened back in October 2022 that are yet to receive a reply.

@jneilliii
Copy link
Contributor

@LuckyX182 any input? @derekantrican I see you have a pending PR, would you be interested in adopting if we don't hear back or possibly you and @valemaio2 combine efforts? Potentially just getting you both contributor rights to the current repo would be a good solution.

@derekantrican
Copy link
Contributor

@jneilliii I don't mind having contributor access, but I don't really want the responsibility of ownership here. I think @valemaio2 as the creator of this issue indicated they wanted to take over ownership

@valemaio2
Copy link
Author

@jneilliii I don't mind having ownership transferred if @derekantrican doesn't want to
Of course, the more contributors the better.

@jneilliii
Copy link
Contributor

@valemaio2 since you already have a fork it's just a matter of updating the plugin listing page to point to yours and add you to the authors list. Make sure to change the software update hook to point to your repo and bump the version and release with the new version number. If you need any pointers, I'd look at this adoption PR as reference of what they changed as part of the process, and don't hesitate to ask any questions for clarification.

#1027

@valemaio2
Copy link
Author

@jneilliii Thank you. Since this is my first public repo on Github, could you please expand on the changing the software update hook? Or even just link me a resource I can read upon?

@derekantrican
Copy link
Contributor

derekantrican commented Feb 1, 2023

@valemaio2 Similar to https://github.com/smartin015/continuousprint/pull/5/files (from the issue @jneilliii linked). To edit in GitHub, go to the repo and press the period (.) key. Find and replace any instances of "LuckyX182" with "valemaio2". Also reference the above linked issue for changes like author, bumping version, etc.

Let me know if you need help (I literally just did this today for another plugin 😄 )

@valemaio2
Copy link
Author

@jneilliii I think I've just done it? I'm still trying to figure out how Github works, sorry. I've been looking at the issue you and derek linked, and did what I could based on that. @derekantrican I've invited you as a collaborator, feel free to accept or decline, as I believe you said you don't mind being a contributor. If you accept, I'll give you proper credit on the plugin homepage, and wherever else is needed.

@jneilliii
Copy link
Contributor

Not quite. I closed your PR because it's not complete. I'll assist you with the necessary changes later tonight when I get home after work.

@derekantrican
Copy link
Contributor

Has there been any update on getting this migration completed? Let me know if I can assist

@jneilliii
Copy link
Contributor

Sorry, dropped the ball on this one. I just looked at @valemaio2 's fork and it needs to have issues enabled and release created for version 0.3.4 before any overlays/adjustments to the plugin listing are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

3 participants