Adopt continuousprint plugin #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneilliii
approved these changes
Mar 13, 2022
|
@smartin015 This is fantastic news! Once you have everything sorted out for the adoption process, could you please give an ETA on when you might be able to merge https://github.com/willindiana/continuousprint into the master branch? It appears that he's successfully fixed a bug that has made the software unreliable for some people. |
|
Hey @DanaViolet - I'll sync up with Will next week on getting those changes merged in. Edit: we're now tracking implementation/merging in smartin015/continuousprint#6. |
This was referenced Feb 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1021
I completed smartin015/continuousprint#5 to bump the plugin version and replace occurrences of the old repository. Then I created a new release: https://github.com/smartin015/continuousprint/releases/tag/1.4.1
The changes in the new release have been simmering for over a month (see smartin015/continuousprint#3) so odds are good of a (relatively) painless switchover. I think I got all the references, but I'd really appreciate some careful review to make sure.
Let me know if there's anything extra I need to do! Thanks in advance :)