Do not attempt to retrieve the applied Helm manifest when ResourceStatusCheck is disabled #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for the helm release revision being retrieved
APErebus
approved these changes
Dec 10, 2024
source/Calamari/Kubernetes/Conventions/Helm/HelmManifestAndStatusReporter.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of OctopusDeploy/Issues#9160
The Helm upgrade command should not try to retrieve the applied manifest when the ResourceStatusCheck flag is not set (assuming none of the Manifest Inspection and Live Object Status feature toggles are enabled either).
This PR additionally includes more verbose logging around the Helm release name and revision number that Calamari tries to retrieve, to help with debugging cases where the
PollForManifestmethod times out and fails.[sc-99264]