Support PollingOverWebSocket for net60 Services #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwoctopusdeploy
force-pushed
the
sast/improve-websocket-support-in-clientandservicebuilder
branch
2 times, most recently
from
07eccfc
to
0b9d243
Compare
Base automatically changed from
sast/improve-websocket-support-in-clientandservicebuilder
to
main
July 6, 2023 23:56
nathanwoctopusdeploy
force-pushed
the
sast/everyone-gets-websockets
branch
from
be131c3
to
39d70c2
Compare
nathanwoctopusdeploy
force-pushed
the
sast/everyone-gets-websockets
branch
2 times, most recently
from
607513e
to
1fa23ab
Compare
nathanwoctopusdeploy
changed the title
| @@ -8,7 +8,7 @@ static class WebSocketSslCertificateHelper | |||
| { | |||
| internal static void AddSslCertToLocalStore() | |||
| { | |||
| var store = new X509Store(StoreName.My, StoreLocation.LocalMachine); | |||
| var store = new X509Store(StoreName.My, StoreLocation.CurrentUser); | |||
There was a problem hiding this comment.
Linux LocalMachine is read-only
There was a problem hiding this comment.
This change is adding support for websockets on linux?
There was a problem hiding this comment.
Ability to install the cert on Linux, we still have an issue where we can't run any tests due to pollingoverwebsockets Client not being able to bind to an SSL port on Linux
LukeButters
reviewed
Jul 24, 2023
source/Halibut.Tests/Support/TestAttributes/FailedWebSocketTestsBecomeInconclusiveAttribute.cs
Outdated
Show resolved
Hide resolved
LukeButters
reviewed
Jul 24, 2023
| #if SUPPORTS_WEB_SOCKET_CERTIFICATE_VALIDATION_CALLBACK | ||
| clientWebSocket.Options.RemoteCertificateValidationCallback = WebSocketServerCertificateValidationCallback(clientWebSocket.Options.RemoteCertificateValidationCallback, connectionId); | ||
| #endif | ||
| ServicePointManager.ServerCertificateValidationCallback = ServerCertificateValidationCallback(ServicePointManager.ServerCertificateValidationCallback); |
There was a problem hiding this comment.
Do we need both to be registered?
There was a problem hiding this comment.
I don't think so. I'll have a play and see!!
|
[sc-53419] |
|
This pull request has been linked to Shortcut Story #53419: Enable WebSocket support on net60 to increase test coverage (just not Linux). |
3 tasks
nathanwoctopusdeploy
force-pushed
the
sast/everyone-gets-websockets
branch
from
f1a359b
to
cb97279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR adds support for WebSocket Services on net60. This will allow net60 Tentacles on Windows and Linux to support PollingOverWebSockets
This does not change the Client requirements e.g. Octopus Server, which must still be run on Windows (net48 or net60) as
HttpListenerdoesn't support SSL binding in net60 on LinuxResults
Before
PollingOverWebSocket Services (Tentacles) had to be run on Windows under net48
After
PollingOverWebSocket Services (Tentacles) can be run on Windows under net48 and net60 and on Linux under net60
How to review this PR
Quality ✔️
Pre-requisites