Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed package reference name comparison in ReleasePlan #167

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

slewis74
Copy link
Contributor

@slewis74 slewis74 commented Mar 4, 2022

Adjust the package reference name check to fix a missing edge case. The comparison should have been checked whether the passed value and the step reference value were both null/empty OR equal using a case-insensitive comparison.

Fixes #166

…/empty packageReferenceName was passed to the method
Copy link
Contributor

@hnrkndrssn hnrkndrssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested changes locally, and all is working as expected 👍

@slewis74 slewis74 merged commit 3c39877 into main Mar 8, 2022
@slewis74 slewis74 deleted the bug-create-release-packagereferences branch March 8, 2022 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create release can fail with a "Sequence contains more than one matching element exception"
2 participants