Fix net462 tests and some async improvements #756
Conversation
borland
changed the title
| #if NETFRAMEWORK | ||
| var codeBase = assembly.CodeBase ?? throw new NotSupportedException($"Cannot get codebase for assembly {assembly}"); | ||
| #else | ||
| var codeBase = assembly.Location; | ||
| #endif |
There was a problem hiding this comment.
Could we just use Assembly.Location for both frameworks?
There was a problem hiding this comment.
Probably, but not definitely.
Microsoft's documentation contains this:
Remarks
In .NET 5 and later versions, for bundled assemblies, the value returned is an empty string..NET Framework only: If the loaded file was shadow-copied, the location is that of the file after being shadow-copied. To get the location before the file has been shadow-copied, use the CodeBase property.
Out of caution, I chose to leave the code untouched for NETFRAMEWORK.
| <PackageReference Include="NSubstitute" Version="4.4.0" /> | ||
| <PackageReference Include="NUnit" Version="3.13.3" /> | ||
| <PackageReference Include="NUnit3TestAdapter" Version="4.5.0" /> | ||
| <PackageReference Include="System.IO.Compression" Version="4.3.0" /> |
There was a problem hiding this comment.
Was the dependency on System.IO.Compression added intentionally?
There was a problem hiding this comment.
Yes, the newer version of NUnit3TestAdapter takes a dependency on it, and it's not built into the BCL in NETFRAMEWORK
Background
We noticed that some of the async/await code in the async
BasicRepositorywas inconsistent.As part of routine maintenance, I cleaned this up.
In doing so, I discovered that the tests had not been running on the
net462target for quite some time, due to a bug in the NUnit test runner that occurred when the .NET 7 SDK was present on the host machine.This issue was fixed in September 2022, and upon upgrading the NUnit runner I discovered that a few breakages/incompatibilities had crept into the codebase.
Results
CS4014,CA1849,CA2012,CA2016which help ensure we are handling async/await correctly.LangVersionto 8 forOctopus.Client.csprojConfigureAwait(false)andasyncmethods inBasicRepository.cs,MixedScopeBaseRepository.csandUserInvitesRepository