Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs to clarify usage of git_ref and git_commit arguments #526

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Update docs to clarify usage of git_ref and git_commit arguments #526

merged 2 commits into from
Jan 28, 2025

Conversation

hnrkndrssn
Copy link
Contributor

[sc-102173]

@hnrkndrssn hnrkndrssn self-assigned this Jan 28, 2025
@hnrkndrssn hnrkndrssn requested a review from a team as a code owner January 28, 2025 04:45
IsaacCalligeros95
IsaacCalligeros95 requested changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@IsaacCalligeros95 IsaacCalligeros95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor edits

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@hnrkndrssn @IsaacCalligeros95
Apply suggestions from code review
40c69a2 
Co-authored-by: Isaac Calligeros <101079287+IsaacCalligeros95@users.noreply.github.com>
IsaacCalligeros95
IsaacCalligeros95 approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@IsaacCalligeros95 IsaacCalligeros95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hnrkndrssn hnrkndrssn merged commit 949b796 into main Jan 28, 2025
6 checks passed
@hnrkndrssn hnrkndrssn deleted the henrik/docs/gitref branch January 28, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacCalligeros95 IsaacCalligeros95 IsaacCalligeros95 approved these changes

@benPearce1 benPearce1 Awaiting requested review from benPearce1

@grace-rehn grace-rehn Awaiting requested review from grace-rehn

Assignees

@hnrkndrssn hnrkndrssn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hnrkndrssn @IsaacCalligeros95