This repository has been archived by the owner on Sep 9, 2024. It is now read-only.
feat:slack connector #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louismurerwa
approved these changes
Apr 19, 2024
ArnavBalyan
reviewed
Apr 20, 2024
| for (const channel of slackChannels) { | ||
| const conversations = await this.fetchChannelConversations(channel.id,config); | ||
| for(const conversation of conversations){ | ||
| const thread = await this.fetchThreadForConversation(channel.id,conversation.ts,config) |
There was a problem hiding this comment.
This seems to be a bug, .ts does not exist on conversation. Similarly, it's non-existent for the references in this file. Consider changing to conversation.id
There was a problem hiding this comment.
Hey id will not work . Please refer to the following doc https://api.slack.com/methods/conversations.history
There was a problem hiding this comment.
Yes, refer to the other comment on this file, ts does not exist on the conversation object
ArnavBalyan
reviewed
Apr 20, 2024
Comment on lines
+147
to
+150
| id: conversations.ts, | ||
| text:conversations.text, | ||
| user: conversations.user | ||
| })) |
There was a problem hiding this comment.
We are assigning conversations.ts to id, not to ts
There was a problem hiding this comment.
Oh right! Missed that!
There was a problem hiding this comment.
Could you please create a PR with the change? Thanks for finding the issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack Connector