Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include models in docker image context #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ehrhart
Copy link

@ehrhart ehrhart commented Jun 7, 2024

Overview

This pull request adds a .dockerignore file pre-configured to prevent the models folder from being included in the Docker image context. This change is intended to reduce the image size and build time by omitting large, unnecessary files.

Changes Made

  1. Added a new .dockerignore file which includes an entry to ignore the models directory, ensuring they are not copied into the Docker image context.

  2. README update: modified the docker run command to mount a volume which contains the models, since they are no longer included in the Docker image.

Motivation

Including models in the Docker image context can significantly increase the size of the Docker image, leading to longer build times and larger image sizes. By excluding these files, we achieve:

  • Faster build times
  • Reduced Docker image size

Testing

  • Verified that the Docker image builds successfully without the models directory.
  • Confirmed that the application runs correctly within the Docker container when mounting the models directory.

@ehrhart ehrhart requested a review from StefanoMenini June 7, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant