Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chromecast support #148

Closed
tzarebczan opened this issue Mar 17, 2022 · 8 comments · Fixed by #306
Closed

Chromecast support #148

tzarebczan opened this issue Mar 17, 2022 · 8 comments · Fixed by #306
Labels
enhancement New feature or request

Comments

@tzarebczan
Copy link
Contributor

Ability to cast videos to chromecast devices
@mpact1984
Copy link

mpact1984 commented Jun 9, 2022 •
edited
Loading

Hi,
i would appreciate this too. The cast button is already implemented, but results in a black screen only. I hope we can enjoy this very soon.

@tzarebczan
Copy link
Contributor Author

Black screen on the TV after you cast? Does it work on Odysee.com on chrome mobile / desktop?

@mpact1984
Copy link

mpact1984 commented Jun 9, 2022 •
edited
Loading

Oh good point.
When i try to cast from the app, it seems the mobile phone (Samsung Galaxy S10) is connecting to the TV, but not more: The TV is switching on and is waiting for a signal. It looks like the Odysee App is not starting to stream. When i press pause and play again in the App, the video is playing again in the Odysee app. But when pressing the cast symbol again it's showing that the app is casting the video to MyDevice.

But (what i have not tested yesterday): When i open Odysee in the chrome browser, and i watch videos inside the chrome browser on this device, i am able to cast to the TV without problems.

I am wondering if there is an issue, because i use Firefox as my default browser on my Android device? And there is no cast option available in firefox.

@kekkyojin
Copy link
Collaborator

odysee-android -this repository- does not yet support Chromecast. Some parts are implemented -as they were on LBRY Android-, but not wired at all.

Maybe @mpact1984 is having the problem with the non-native one?

@mpact1984
Copy link

@kekkyojin Please explain to me what you mean with "the non-native one". The app? I use the Odysee app version from the google play store. Or did you mean the browser, because i switched to a different default browser? Or something complete different.

@kekkyojin
Copy link
Collaborator

The version on the Play Store is the non-native one, which is a different repository than this one. The non-native Odysee Android loads web assets which had been packaged.

@pixel2user pixel2user mentioned this issue Jul 2, 2022
Open
@tzarebczan tzarebczan added the enhancement New feature or request label Jul 5, 2022
@kekkyojin kekkyojin removed their assignment Jul 18, 2022
@kekkyojin
Copy link
Collaborator

Unable to work on this for a time. Unassigning from me.

@tzarebczan
Copy link
Contributor Author

@ktprograms do you have a chromecast? If not, Odysee can reimburse you for one. This would be a good one to work on while I spec out publishing flow.

ktprograms added a commit that referenced this issue Aug 3, 2022
@ktprograms
Chromecast support
e5ad831 
Create PlayerManager and CastHelper classes to handle cast playback as
well as split code for FOSS variant.

PlayerManger initializes players and has methods for changing current
player and initializing player with media URL.

CastHelper holds the CastContext and handles cast button visibility and
the Chromecast introductory overlay.

Remove references to Players in MainActivity and FileViewFragment.
Players are always accessed through the PlayerManager instance.

MediaRouteButton is present in the layout files in the main source set,
since it is not part of a closed source library. Its visibility remains
GONE the entire time in the FOSS variant.

Fix: #148
@ktprograms ktprograms mentioned this issue Aug 3, 2022
Merged
4 tasks
ktprograms added a commit that referenced this issue Aug 3, 2022
@ktprograms
Chromecast support
acdffc2 
Create PlayerManager and CastHelper classes to handle cast playback as
well as split code for FOSS variant.

PlayerManger initializes players and has methods for changing current
player and initializing player with media URL.

CastHelper holds the CastContext and handles cast button visibility and
the Chromecast introductory overlay.

Remove references to Players in MainActivity and FileViewFragment.
Players are always accessed through the PlayerManager instance.

MediaRouteButton is present in the layout files in the main source set,
since it is not part of a closed source library. Its visibility remains
GONE the entire time in the FOSS variant.

Fix: #148
akinwale pushed a commit that referenced this issue Aug 5, 2022
@ktprograms @akinwale
Chromecast support
7ad419e 
Create PlayerManager and CastHelper classes to handle cast playback as
well as split code for FOSS variant.

PlayerManger initializes players and has methods for changing current
player and initializing player with media URL.

CastHelper holds the CastContext and handles cast button visibility and
the Chromecast introductory overlay.

Remove references to Players in MainActivity and FileViewFragment.
Players are always accessed through the PlayerManager instance.

MediaRouteButton is present in the layout files in the main source set,
since it is not part of a closed source library. Its visibility remains
GONE the entire time in the FOSS variant.

Fix: #148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chromecast support OdyseeTeam/odysee-android
4 participants
@akinwale @kekkyojin @tzarebczan @mpact1984