Add delay to player error retries #3233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding more of a delay and another attempt. Can you update the other file where we call the retry function via button click to pass true. Can you give it a test somehow? I think prior to these changes, we'd keep retrying, but now we have a max. Maybe we can improve that later again.
|
I made a corrupted video, and it kind of allows to test. https://odysee.com/@a:f1/corrupted:d Tried to look into adjusting the attempt reset delay to avoid looping, but not sure how it would behave in the real issue. So left as is. The delays themselves do work. And also the manual button. |
|
Thanks for the fix and testing! Let's give this a try... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.