Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move event and delayed inbox messages read to the bridge #87

Merged
merged 9 commits into from
Oct 31, 2023
Merged

Move event and delayed inbox messages read to the bridge #87

merged 9 commits into from
Oct 31, 2023

Conversation

yahgwai
Copy link
Contributor

@yahgwai yahgwai commented Oct 26, 2023 •
edited
Loading

This makes state and events more consistent when sequencer inboxes are replaced.

  • Events are emitted from the bridge
  • Event signature changed due to addition of seq inbox address
  • Requires a call to postUpgradeInit to initialise total delayed messages read

@cla-bot cla-bot bot added the s label Oct 26, 2023
@yahgwai yahgwai changed the base branch from main to seq-inbox-opt October 26, 2023 12:11
@yahgwai yahgwai changed the title Move event and delayed inbox messages read to the brj] Move event and delayed inbox messages read to the bridge Oct 26, 2023
@yahgwai yahgwai marked this pull request as ready for review October 26, 2023 13:32
gzeoneth
gzeoneth approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@gzeoneth gzeoneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some comments

src/bridge/ICommon.sol Outdated Show resolved Hide resolved
src/bridge/AbsBridge.sol Show resolved Hide resolved
src/bridge/AbsBridge.sol Outdated Show resolved Hide resolved
gzeoneth
gzeoneth approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@gzeoneth gzeoneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should remove those dot file before merging

@yahgwai yahgwai merged commit 3646a78 into seq-inbox-opt Oct 31, 2023
4 checks passed
@yahgwai yahgwai deleted the seq-inbox-bridge branch October 31, 2023 12:25
@gzeoneth gzeoneth mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzeoneth gzeoneth gzeoneth approved these changes

@PlasmaPower PlasmaPower Awaiting requested review from PlasmaPower

Assignees
No one assigned
Labels
s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahgwai @gzeoneth