Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to build against geth merge-v1.11.4 branch #1652

Merged
merged 5 commits into from
Jun 7, 2023
Merged

Conversation

Tristan-Wilson
Copy link
Member

Most of the changes were related to upstream's core.Message change. core.Message has been changed from interface to struct and types.Message has been removed. We used the core.Message interface in a number of places and it needed to be changed to a pointer to the core.Message struct to maintain the same semantics.

This depends on OffchainLabs/go-ethereum#221

Testing done

make push passes

Start node

Node is able to be started from a genesis snapshot and starts syncing

./target/bin/nitro  --l1.url <L1 url>  --l2.chain-id=42161 --node.rpc.classic-redirect=https://arb1.arbitrum.io/rpc   --http.api=net,web3,eth,debug --http.corsdomain=* --http.addr=0.0.0.0 --http.vhosts=*  --persistent.global-config /home/tristan/offchain/geth-upgrade/nitro-genesis/

Most of the changes were related to upstream's core.Message change.
core.Message has been changed from interface to struct and types.Message
has been removed. We used the core.Message interface in a number of
places and it needed to be changed to a pointer to the core.Message
struct to maintain the same semantics.
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label May 20, 2023
Base automatically changed from merge-v1.11.3 to master June 6, 2023 16:17
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 9b79958 into master Jun 7, 2023
@PlasmaPower PlasmaPower deleted the merge-v1.11.4 branch June 7, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants