Improve stability of getNodeCreationBlock for L3s #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
tsahee
requested changes
Sep 30, 2024
staker/rollup_watcher.go
Outdated
| if r.supportedL3Method.Load() { | ||
| return nil, fmt.Errorf("getNodeCreationBlockForLogLookup failed despite previously succeeding: %w", err) | ||
| } | ||
| log.Trace("failed to call getNodeCreationBlockForLogLookup, falling back on node CreatedAtBlock field", "err", err) |
There was a problem hiding this comment.
Should be at least Info - since this will be printed exactly once, and could help debugging some weird cases.
There was a problem hiding this comment.
Makes sense. I'm a bit hesitant in general to make stuff like this "info" because 3rd party teams will complain about the "issue" in their logs, or think it's the cause of some other issue, but it indeed might be useful for debugging. I'll upgrade it to info, and maybe think about rewording it.
There was a problem hiding this comment.
Upgraded to info and reworded a bit to help clarify it for 3rd party teams
tsahee
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a spurious failure of
getNodeCreationBlockForLogLookupdue toNO_NODE(e.g. because it was routed to a node that's slightly behind others) would cause the node to permanently stop using the method, breaking it for L3s. Instead, this PR both recognizes that NO_NODE is an ephemeral error and permanently saves the fact that the method previously succeeded.