[config change] use MessageCommitMode when executing future head block messages

arbos/block_processor.go

@@ -144,6 +144,7 @@ func ProduceBlock(
  chainContext core.ChainContext,
  chainConfig *params.ChainConfig,
  isMsgForPrefetch bool,
+ runMode core.MessageRunMode,
 ) (*types.Block, types.Receipts, error) {
  txes, err := ParseL2Transactions(message, chainConfig.ChainID)
  if err != nil {
@@ -153,7 +154,7 @@ func ProduceBlock(
 
  hooks := NoopSequencingHooks()
  return ProduceBlockAdvanced(
- message.Header, txes, delayedMessagesRead, lastBlockHeader, statedb, chainContext, chainConfig, hooks, isMsgForPrefetch,
+ message.Header, txes, delayedMessagesRead, lastBlockHeader, statedb, chainContext, chainConfig, hooks, isMsgForPrefetch, runMode,
  )
 }
 
@@ -168,6 +169,7 @@ func ProduceBlockAdvanced(
  chainConfig *params.ChainConfig,
  sequencingHooks *SequencingHooks,
  isMsgForPrefetch bool,
+ runMode core.MessageRunMode,
 ) (*types.Block, types.Receipts, error) {
 
  state, err := arbosState.OpenSystemArbosState(statedb, nil, true)
@@ -318,6 +320,7 @@ func ProduceBlockAdvanced(
  tx,
  &header.GasUsed,
  vm.Config{},
+ runMode,
  func(result *core.ExecutionResult) error {
  return hooks.PostTxFilter(header, state, tx, sender, dataGas, result)
  },

cmd/replay/main.go

@@ -14,6 +14,7 @@ import (
 
  "github.com/ethereum/go-ethereum/common"
  "github.com/ethereum/go-ethereum/consensus"
+ "github.com/ethereum/go-ethereum/core"
  "github.com/ethereum/go-ethereum/core/rawdb"
  "github.com/ethereum/go-ethereum/core/state"
  "github.com/ethereum/go-ethereum/core/types"
@@ -291,7 +292,7 @@ func main() {
  message := readMessage(chainConfig.ArbitrumChainParams.DataAvailabilityCommittee)
 
  chainContext := WavmChainContext{}
- newBlock, _, err = arbos.ProduceBlock(message.Message, message.DelayedMessagesRead, lastBlockHeader, statedb, chainContext, chainConfig, false)
+ newBlock, _, err = arbos.ProduceBlock(message.Message, message.DelayedMessagesRead, lastBlockHeader, statedb, chainContext, chainConfig, false, core.MessageReplayMode)
  if err != nil {
  panic(err)
  }

execution/gethexec/block_recorder.go

@@ -8,6 +8,7 @@ import (
 
  "github.com/ethereum/go-ethereum/arbitrum"
  "github.com/ethereum/go-ethereum/common"
+ "github.com/ethereum/go-ethereum/core"
  "github.com/ethereum/go-ethereum/core/types"
  "github.com/ethereum/go-ethereum/ethdb"
  "github.com/ethereum/go-ethereum/log"
@@ -154,6 +155,7 @@ func (r *BlockRecorder) RecordBlockCreation(
  chaincontext,
  chainConfig,
  false,
+ core.MessageReplayMode,
  )
  if err != nil {
  return nil, err

execution/gethexec/executionengine.go

@@ -505,6 +505,7 @@ func (s *ExecutionEngine) sequenceTransactionsWithBlockMutex(header *arbostypes.
  s.bc.Config(),
  hooks,
  false,
+ core.MessageCommitMode,
  )
  if err != nil {
  return nil, err
@@ -661,6 +662,10 @@ func (s *ExecutionEngine) createBlockFromNextMessage(msg *arbostypes.MessageWith
  statedb.StartPrefetcher("TransactionStreamer")
  defer statedb.StopPrefetcher()
 
+ runMode := core.MessageCommitMode
+ if isMsgForPrefetch {
+ runMode = core.MessageReplayMode
+ }
  block, receipts, err := arbos.ProduceBlock(
  msg.Message,
  msg.DelayedMessagesRead,
@@ -669,6 +674,7 @@ func (s *ExecutionEngine) createBlockFromNextMessage(msg *arbostypes.MessageWith
  s.bc,
  s.bc.Config(),
  isMsgForPrefetch,
+ runMode,
  )
 
  return block, statedb, receipts, err

system_tests/state_fuzz_test.go

@@ -38,6 +38,7 @@ func BuildBlock(
  chainConfig *params.ChainConfig,
  inbox arbstate.InboxBackend,
  seqBatch []byte,
+ runMode core.MessageRunMode,
 ) (*types.Block, error) {
  var delayedMessagesRead uint64
  if lastBlockHeader != nil {
@@ -59,11 +60,13 @@ func BuildBlock(
  }
  err = l1Message.FillInBatchGasCost(batchFetcher)
  if err != nil {
- return nil, err
+ // skip malformed batch posting report
+ // nolint:nilerr
+ return nil, nil
  }
 
  block, _, err := arbos.ProduceBlock(
- l1Message, delayedMessagesRead, lastBlockHeader, statedb, chainContext, chainConfig, false,
+ l1Message, delayedMessagesRead, lastBlockHeader, statedb, chainContext, chainConfig, false, runMode,
  )
  return block, err
 }
@@ -127,7 +130,7 @@ func (c noopChainContext) GetHeader(common.Hash, uint64) *types.Header {
 }
 
 func FuzzStateTransition(f *testing.F) {
- f.Fuzz(func(t *testing.T, compressSeqMsg bool, seqMsg []byte, delayedMsg []byte) {
+ f.Fuzz(func(t *testing.T, compressSeqMsg bool, seqMsg []byte, delayedMsg []byte, runModeSeed uint8) {
  if len(seqMsg) > 0 && daprovider.IsL1AuthenticatedMessageHeaderByte(seqMsg[0]) {
  return
  }
@@ -201,7 +204,9 @@ func FuzzStateTransition(f *testing.F) {
  positionWithinMessage: 0,
  delayedMessages: delayedMessages,
  }
- _, err = BuildBlock(statedb, genesis, noopChainContext{}, params.ArbitrumOneChainConfig(), inbox, seqBatch)
+ numberOfMessageRunModes := uint8(core.MessageReplayMode) + 1 // TODO update number of run modes when new mode is added
+ runMode := core.MessageRunMode(runModeSeed % numberOfMessageRunModes)
+ _, err = BuildBlock(statedb, genesis, noopChainContext{}, params.ArbitrumOneChainConfig(), inbox, seqBatch, runMode)
  if err != nil {
  // With the fixed header it shouldn't be possible to read a delayed message,
  // and no other type of error should be possible.