Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NIT-2868] Allow pubsub interface to return an error #2753

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

[NIT-2868] Allow pubsub interface to return an error #2753

wants to merge 12 commits into from
+53 −1

Conversation

amsanghi
Copy link
Contributor

Fixes: NIT-2868

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Oct 24, 2024
@amsanghi amsanghi marked this pull request as ready for review October 28, 2024 15:04
magicxyyz
magicxyyz reviewed Nov 27, 2024
View reviewed changes
pubsub/consumer.go Outdated Show resolved Hide resolved
magicxyyz
magicxyyz requested changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments/questions. Except that it would be nice to add a test for the SetError feature.

pubsub/producer.go Outdated Show resolved Hide resolved
validator/valnode/redis/consumer.go Outdated Show resolved Hide resolved
@amsanghi amsanghi requested a review from magicxyyz January 21, 2025 15:16
magicxyyz
magicxyyz requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the only missing thing is a test for SetError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicxyyz magicxyyz magicxyyz requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amsanghi @magicxyyz