Test gas usage of hostios that don't have good EVM equivalents #2767
+192
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
tsahee
requested changes
Nov 7, 2024
gligneul
reviewed
Nov 7, 2024
system_tests/program_gas_test.go
Outdated
Comment on lines
44
to
48
| funcName := matchSnake.ReplaceAllStringFunc(tc.hostio, func(s string) string { | ||
| return strings.ToUpper(strings.TrimPrefix(s, "_")) | ||
| }) | ||
| signature := fmt.Sprintf("%v()", funcName) | ||
| data := crypto.Keccak256([]byte(signature))[:4] |
There was a problem hiding this comment.
You could create an interface in the solidity mocks to facilitate the generation of the call args.
There was a problem hiding this comment.
I want to avoid doing that 😬.
Ideally we could use an ABI that is generated directly from the rust smart contract, but we don't have a setup for this yet, so I decided to build calldata in a more low level approach since tests are simple.
diegoximenes
force-pushed
the
test_gas_usage_hostio
branch
from
30a4518
to
ec8a8b1
Compare
hostios with multiple arguments
diegoximenes
force-pushed
the
test_gas_usage_hostio
branch
from
ec8a8b1
to
7c6cf62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves NIT-2829
Test gas usage of hostios that don't have good EVM equivalents