TestArbos11To32Upgrade #2837
Merged
TestArbos11To32Upgrade #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
diegoximenes
force-pushed
the
test_arbos_upgrade_divergence
branch
from
bdc48f7 to
4598b50
Compare
gligneul
previously approved these changes
Dec 19, 2024
There was a problem hiding this comment.
There are tons of other changes in the contracts. Maybe the branch you chose as a base wasn't the correct one?
There was a problem hiding this comment.
nitro-contracts/pre-bold was branched off nitro-contracts/main.
There were some changes introduced in nitro-contracts/main that were not included in nitro's contracts submodule, these are the changes in the contracts that you are observing.
gligneul
approved these changes
Dec 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2837 +/- ##
==========================================
- Coverage 22.60% 22.53% -0.07%
==========================================
Files 269 269
Lines 39696 39696
==========================================
- Hits 8974 8947 -27
- Misses 29248 29272 +24
- Partials 1474 1477 +3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves NIT-2975
Adds a test which guarantees that there is no problem if a transaction that executes an instruction like mcopy, that is available in ArbOS 32 but not in ArbOS 11, is included in the same block that the ArbOS 11 to 32 upgrade happens.
Depends on OffchainLabs/nitro-contracts#284