Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gosec ci lint #807

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Fix gosec ci lint #807

merged 1 commit into from
Jul 18, 2022

Conversation

rachel-bousfield
Copy link
Contributor

Adds header-reading timeouts to suppress the slowloris lint

@cla-bot cla-bot bot added the cla-signed label Jul 18, 2022
@rachel-bousfield rachel-bousfield added Type: CI node Changes the node software AnyTrust labels Jul 18, 2022
PlasmaPower
PlasmaPower approved these changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should probably make these configurable and add more timeouts, but this fixes CI and we can follow up on that later.

@PlasmaPower PlasmaPower enabled auto-merge July 18, 2022 22:07
@PlasmaPower PlasmaPower mentioned this pull request Jul 18, 2022
Closed
@PlasmaPower PlasmaPower merged commit 08414bd into master Jul 18, 2022
@PlasmaPower PlasmaPower deleted the fix-slowloris-ci branch July 18, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlasmaPower PlasmaPower PlasmaPower approved these changes

Assignees
No one assigned
Labels
AnyTrust cla-signed node Changes the node software Type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rachel-bousfield @PlasmaPower