Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oneway and Mutual Dependency ElementRelationShip #1360

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mohammed-MSFT
Copy link
Contributor

No description provided.

Copy link

@ali-ms ali-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said in channel, let's have a meeting to discuss this. There's potentially incorrect understanding of what is and how to use RT on the sample app team.

@@ -20,11 +20,17 @@ urlFragment: officedev-microsoft-teams-samples-app-hello-world-nodejs
* Tabs
* Bots
* Messaging Extensions
* Element RelationShip Property
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm new to sample app creation, but why do we not create a separate RT sample app yet use existing hello-world app to illustrate RT usage? This might create confusion to developers.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also so far only elementRelationshipSet is covered. I don't see "hostMustSupportFunctionalities" yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

},
"name": {
"short": "Hello World",
"full": "Hello World App for Microsoft Teams"
"short": "ElementRelationshipSet",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an app for ElementRelationshipSet or for Hello World?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created New sample, Comment fixed

"title": "Card title"
}
{
"id": "composeExt_ID",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a searchME dependsOn bot case. Yet our hero case for RT in terms of command level dependency is really actionME dependsOn bot. And this actionME should also contain a botSentCard scenario.

Also suggest we explicitly use the "type" field to call out the type of the command.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

"botId": "${{AAD_APP_CLIENT_ID}}",
"commands": [
{
"id": "getRandomText",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest we use a more meaningful value for the id field, despite not necessarily needing UUID.

"scopes": [
"personal"
"elementRelationshipSet": {
"oneWayDependencies": [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add one more oneWayDepend scenario that's about a tab dependsOn ME (at ME level, instead of command level)

![GroupChatMessageExt](Images/ElementRelationShip/9.GC_MsgExtension.png)

**Outlook - Oneway Dependency**
**Outlook doesn't support bots, and since Message Extensions depend on a bot, the Message Extension doesn't work in Outlook**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong in two aspects:

  1. If RT is used correctly to specify actionME dependsOn bot, then the actionME shouldn't even show up in Outlook. But in your illustration, the command shows up.
  2. The fact that the command shows up as your illustration displays is actually a bug - the command shows up yet doesn't work. It doesn't represent the correct end result of using RT.

@Mohammed-MSFT Mohammed-MSFT added duplicate This issue or pull request already exists invalid This doesn't seem right DO NOT MERGE Do not merge the PR due to incomplete changes or feature hasn't released yet. labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Do not merge the PR due to incomplete changes or feature hasn't released yet. duplicate This issue or pull request already exists invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants