Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pacakge.json dependencies #774

Merged
merged 2 commits into from
May 13, 2023
Merged

Update pacakge.json dependencies #774

merged 2 commits into from
May 13, 2023

Conversation

millerds
Copy link
Contributor

A new version of unzipper was published that had a bug in it the breaks the generator project unzipping. This fix updates the package dependencies to the specific working version. I also updates a string for one of the templates.

Thank you for your pull request. Please provide the following information.


  1. Do these changes impact User Experience? (e.g., how the user interacts with Yo Office and/or the files and folders the user sees in the project that Yo Office creates)

    • Yes
    • No

    If Yes, briefly describe what is impacted.

  2. Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins)

    • Yes
    • No

    If Yes, briefly describe what is impacted.

  3. Validation/testing performed:

Ran the generator to view the project output and the ran the generated project.

  1. Platforms tested:

    • Windows
    • Mac

@millerds millerds requested a review from a team as a code owner May 11, 2023 22:05
Adrian-MSFT
Adrian-MSFT previously approved these changes May 12, 2023
@millerds millerds merged commit d32946d into OfficeDev:master May 13, 2023
@millerds millerds deleted the fix-unzipper branch May 13, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants