Fix intermittent build errors caused by conflicting definitions for setInterval #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ydogandjiev
approved these changes
Apr 26, 2017
charpercyr
pushed a commit
that referenced
this pull request
Nov 8, 2021
…#41) - Minimalistic Bundle analysis app which uses teams-js-app-sdk and outputs zipped webpack stats - Script to collect bundle analysis from all the packages and collect at one location - Azure pipeline changes to run bundle analysis and collect on every merge to main/PR. - Azure pipeline changes to publish collected bundle-analyses as artifact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In @types/node which is auto-installed in the CI builds,
setIntervalreturns aNodeJS.Timerobject instead of just a number.I'm not clear on why this is just now suddenly manifesting and only in the CI build, or why the node typings are being downloaded for a web project (based on logs I suspect it has something to do with the gulp-typings install; we should move to use the @types pattern instead in the future), but being explicit about using the
setIntervalon the window object should disambiguate properly.See details here: microsoft/TypeScript#842