Skip to content

[PowerPoint] Add export-import-slide snippet #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 6, 2025

Conversation

ElizabethSamuel-MSFT
Copy link
Contributor

@ElizabethSamuel-MSFT ElizabethSamuel-MSFT commented May 1, 2025

will add API mappings later

Copy link
Member

@davidchesnut davidchesnut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although two suggestions.

  • The snippet will crash if you click to import before you exported. Would be good to add a check that the localstorage item exists.
  • Would be nice if the image that appears in the task pane (after import) is imported (or surround in a box or something.

Copy link
Member

@davidchesnut davidchesnut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor suggestion, but looks good!

ElizabethSamuel-MSFT and others added 2 commits May 6, 2025 16:15
Co-authored-by: David Chesnut <davech@microsoft.com>
@ElizabethSamuel-MSFT ElizabethSamuel-MSFT merged commit 80ee730 into main May 6, 2025
1 check passed
@ElizabethSamuel-MSFT ElizabethSamuel-MSFT deleted the eliz-ppt-export-import-slide branch May 6, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants