Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

Tabs in PersonaCard not switching #236

Closed
TBag opened this issue Dec 17, 2015 · 2 comments
Closed

Tabs in PersonaCard not switching #236

TBag opened this issue Dec 17, 2015 · 2 comments
Labels

Comments

@TBag
Copy link
Contributor

TBag commented Dec 17, 2015

When you have a page with two persona cards on it the tabs in the persona cards only switch for the first persona card on the page.

This is the file that is the culprit.

https://github.com/OfficeDev/Office-UI-Fabric/blob/master/src/components/PersonaCard/Jquery.PersonaCard.js

How to repro using the attached demo project:

a. In the Index.cshtml file, un-comment the Microsoft out-of-the-box Jquery.PersonaCard.js reference, and comment out the Jquery.PersonaCard.FIX.js reference.
b. RUN the sample,
c. Click first person, then click the tabs in the persona card. It works.
d. Click first person to hide persona card.
e. Click second person, try to switch tabs in the persona card, it does not work.

DemoIssue.zip

Here's the differences in the out-of-the-box file and the fixed file.

personacardfix

@ericthompson
Copy link
Contributor

This is a great catch - your fix finds the correct card. This is a pretty gnarly scoping issue, and your fix is exactly what we would do. Would you mind submitting a pull request with this fix in it?

TBag added a commit to TBag/Office-UI-Fabric that referenced this issue Dec 18, 2015
TBag added a commit to TBag/Office-UI-Fabric that referenced this issue Dec 18, 2015
TBag added a commit to TBag/Office-UI-Fabric that referenced this issue Jan 4, 2016
gokunymbus added a commit that referenced this issue Jan 5, 2016
@ericthompson
Copy link
Contributor

Thanks for the help, @TBag!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants