This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
Fix for #203 #228
Merged
Fix for #203 #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only issue here seems to be what we were saying in scrum earlier: There's a flicker when you click the close button. Also I noticed that the event for close button is 'mousedown'. Seems like it should just be a click or mouseup. Haven't tested it but this might contribute to the flicker. |
| @@ -82,6 +89,7 @@ | |||
| display: none; | |||
| font-size: @ms-font-size-l; | |||
| color: @ms-color-white; | |||
| z-index: 2; | |||
There was a problem hiding this comment.
Use mixin @ms-zindex-front ? or the back version.
|
APPPROOVEDZZZZ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the whole input field clickable. Fixed bug where the close button would reappear after clicking.