This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
Better error handling in our Build #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added NewJSHint Plugin
- Added plumber to all tasks - Removed.on() syntax from all tasks - Added task to fail build if errors exist - Added more functionality around tracking errors.
- Removed fake error from LESS.
- Removed testing code.
- Fixed intentional less error
- Added new utility for adding ignore flag to an array of files. - Wrapped map() in a function to prevent the pipe breaking. - Resolved less hinting errors - Resolved all jsHinting Errors.
…st and a src. - Added a new task just for ignored linting files.
…into miljo/better-error-handling # Conflicts: # src/less/Fabric.less [RESOLVED]
| @@ -20,23 +20,51 @@ gulp.task('ComponentSamples-nuke', function () { | |||
| // Copying Files Tasks | |||
| // ---------------------------------------------------------------------------- | |||
|
|
|||
There was a problem hiding this comment.
Add white space on Line 100.
added 2 commits
January 12, 2016 17:02
- Added more linting options - Added and fixed the less linting task.
- Added custom error handling function for Sass - Created a task to set config on Fabric Build. - Removed scss lint due to too many dependencies (Ruby etc)
…e for our library files because of the period in the middle of the file names.
…into miljo/better-error-handling # Conflicts: # src/components/Toggle/Toggle.less [RESOLVED]
| "newcap": false, | ||
| "undef": true, | ||
| "unused": true, | ||
| "browser": true |
| this.addWarning = function(warning) { | ||
| warnings.push(warning); | ||
| return; | ||
| }; |
| @@ -168,23 +168,33 @@ | |||
| overflow-y: auto; | |||
| } | |||
|
|
|||
| .ms-PersonaCard-detailChat { margin-left: 0 !important; } | |||
There was a problem hiding this comment.
Removing all these !importants makes me a little nervous, but I tested them, and didn't see any regressions!
|
approved -- looks great! |
| fileExtension = Config.lessExtension; | ||
| } | ||
|
|
||
| gulp.task('Fabric-buildStyles', ['Fabric-configureBuild', 'Fabric-styleHinting'], function () { |
There was a problem hiding this comment.
When I put an error into a Less file and build, the console outputs the error 9 times.
There was a problem hiding this comment.
Which less file?
|
I like what you got! Nice job! Approved. |
gokunymbus
added a commit
that referenced
this pull request
Jan 15, 2016
Better error handling in our Build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty big update to the build including fixes to all JavaScript files for linting errors. The following changes will add: