This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 467
Remove LESS #303
Merged
Merged
Remove LESS #303
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6557025
Remove all component LESS files.
136696f
Remove LESS build processes and change task names.
4ce8033
Remove core LESS files and update default build tasks to use Sass.
9a05af1
Remove LESS from samples.
fc69517
Remove LESS packages.
4373c43
Remove style hinting, which is LESS-only.
3d34eaa
No longer copy LESS assets in build.
19154ed
Remove LESS dist folder.
8175fe3
Remove the remaining LESS build processes and LESS-to-Sass converter.
b597b4e
Merge branch 'master' into miwhea/remove-less
5078685
Removing a LESS file that was accidentally included in a merge from m…
7048d80
- Testing Sass Linting
5e16c12
- Removed the configure environment task for LESS and SASS
8cf9c19
Merge branch 'master' of https://github.com/OfficeDev/Office-UI-Fabri…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -137,8 +137,6 @@ var ErrorHandling = function() { | |
switch(error.plugin) { | ||
case 'gulp-autoprefixer': | ||
break; | ||
case 'gulp-less': | ||
break; | ||
case 'gulp-sass': | ||
break; | ||
default: | ||
|
@@ -186,54 +184,7 @@ var ErrorHandling = function() { | |
}); | ||
}; | ||
/** | ||
* LESSHint error handler | ||
* @param {object} file Data containing file information | ||
* @param {function} cb Callback data with error or no arguments | ||
*/ | ||
this.LESSHintErrors = function(file, cb) { | ||
return map(function (file, cb) { | ||
|
||
if (!file.lesshint.success) { | ||
file.lesshint.results.forEach(function (err) { | ||
if (err) { | ||
var errorString = that.createLineErrorMessage( | ||
gulputil.colors.yellow(err.severity) + ' ' + err.message, | ||
err.file, | ||
err.line, | ||
err.source, | ||
'NA', | ||
'' | ||
); | ||
if (err.severity == "warning") { | ||
gulputil.log(errorString); | ||
that.addWarning(errorString); | ||
} else { | ||
that.generatePluginError('lessHint', errorString); | ||
} | ||
} | ||
}); | ||
} | ||
return cb(null, file); | ||
}); | ||
}; | ||
/** | ||
* Less Compiler error handler | ||
* @param {object} error An object containing the error data. | ||
*/ | ||
this.LESSCompileErrors = function(error) { | ||
var errorString = that.createLineErrorMessage( | ||
error.filename, | ||
error.line, | ||
error.column, | ||
'No Code', | ||
error.message | ||
); | ||
that.generatePluginError('Less compiler', errorString); | ||
console.log(error); | ||
this.emit('end'); | ||
} | ||
/** | ||
* Less Compiler error handler | ||
* Sass Compiler error handler | ||
* @param {object} error An object containing the error data. | ||
*/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above: even if we aren't adding SASS linting here, it's super important that we do add it shortly. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding it back right now |
||
this.SASSCompileErrors = function(error) { | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, but mind the indentation--looks like a spaces/tabs diff issue