Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

Add check for selecting option from the dropdown #449

Merged
merged 2 commits into from
Mar 29, 2016

Conversation

MIchaelMainer
Copy link
Member

Line 133 -- added !$(this).hasClass('is-disabled') to check that the currently selected option is not disabled. Current behavior is the disabled option raises a change event. Updated behavior is to check that the option is disabled and not raise a change event on a disabled option.

Trimmed whitespace

@msftclas
Copy link

Hi @MIchaelMainer, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Michael Mainer). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@mikewheaton
Copy link
Contributor

Good idea, we shouldn't fire an event if the option is disabled. Looks good to me. One more approver and we can merge it in.

@wdo3650
Copy link
Contributor

wdo3650 commented Mar 29, 2016

@MIchaelMainer thanks for spotting this. Looks good to me.

@wdo3650 wdo3650 merged commit 95bf363 into OfficeDev:master Mar 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants