Skip to content
This repository has been archived by the owner on Mar 26, 2019. It is now read-only.

Null in ContextualHost caused by not removing handler #166

Closed
aminry opened this issue Oct 26, 2016 · 1 comment
Closed

Null in ContextualHost caused by not removing handler #166

aminry opened this issue Oct 26, 2016 · 1 comment

Comments

@aminry
Copy link
Contributor

aminry commented Oct 26, 2016

This happens, when we create multiple callouts.
Since we are not removing the keyUp listener, it will call dispose on all existing callout, and causes null exceptions.
null2
null1
aminry added a commit to aminry/office-ui-fabric-js that referenced this issue Oct 26, 2016
@aminry
Fix null in ContextualHost caused by not removing handler OfficeDev#166
67525a6 
This happens, when we create multiple callouts.
Since we are not removing the keyUp listener, it will call dispose on all existing callout, and causes null exceptions.
aminry added a commit to aminry/office-ui-fabric-js that referenced this issue Oct 26, 2016
@aminry
Merge pull request #1 from aminry/Fix-null-in-ContextualHost
371151f 
Fix null in ContextualHost caused by not removing handler OfficeDev#166
@aminry
Copy link
Contributor Author

aminry commented Oct 26, 2016 •
edited
Loading

I have a Pull Request which fixes this issue
#167

@aminry aminry closed this as completed Oct 29, 2016
Jahnp pushed a commit that referenced this issue Nov 3, 2016
@aminry @Jahnp
Fix null in ContextualHost caused by not removing handler #166 (#167)
38f129a 
This happens, when we create multiple callouts.
Since we are not removing the keyUp listener, it will call dispose on all existing callout, and causes null exceptions.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aminry