Skip to content
This repository has been archived by the owner on Mar 26, 2019. It is now read-only.

ChoiceFieldGroup: use <li> instead of <div>, add list-style: none to ms-ChoiceGroup-list class #284

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions ghdocs/components/ChoiceFieldGroup.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Used to indicate a single choice from multiple options.
&lt;ul class&#x3D;&quot;ms-ChoiceFieldGroup-list&quot;&gt;


&lt;div class&#x3D;&quot;ms-RadioButton&quot;&gt;
&lt;li class&#x3D;&quot;ms-RadioButton&quot;&gt;
&lt;input tabindex&#x3D;&quot;-1&quot; type&#x3D;&quot;radio&quot; class&#x3D;&quot;ms-RadioButton-input&quot;&gt;
&lt;label role&#x3D;&quot;radio&quot;
class&#x3D;&quot;ms-RadioButton-field &quot;
Expand All @@ -43,10 +43,10 @@ Used to indicate a single choice from multiple options.
&gt;
&lt;span class&#x3D;&quot;ms-Label&quot;&gt;Option 1&lt;/span&gt;
&lt;/label&gt;
&lt;/div&gt;
&lt;/li&gt;


&lt;div class&#x3D;&quot;ms-RadioButton&quot;&gt;
&lt;li class&#x3D;&quot;ms-RadioButton&quot;&gt;
&lt;input tabindex&#x3D;&quot;-1&quot; type&#x3D;&quot;radio&quot; class&#x3D;&quot;ms-RadioButton-input&quot;&gt;
&lt;label role&#x3D;&quot;radio&quot;
class&#x3D;&quot;ms-RadioButton-field &quot;
Expand All @@ -56,10 +56,10 @@ Used to indicate a single choice from multiple options.
&gt;
&lt;span class&#x3D;&quot;ms-Label&quot;&gt;Option 2&lt;/span&gt;
&lt;/label&gt;
&lt;/div&gt;
&lt;/li&gt;


&lt;div class&#x3D;&quot;ms-RadioButton&quot;&gt;
&lt;li class&#x3D;&quot;ms-RadioButton&quot;&gt;
&lt;input tabindex&#x3D;&quot;-1&quot; type&#x3D;&quot;radio&quot; class&#x3D;&quot;ms-RadioButton-input&quot;&gt;
&lt;label role&#x3D;&quot;radio&quot;
class&#x3D;&quot;ms-RadioButton-field is-disabled &quot;
Expand All @@ -70,10 +70,10 @@ Used to indicate a single choice from multiple options.
&gt;
&lt;span class&#x3D;&quot;ms-Label&quot;&gt;Option 3&lt;/span&gt;
&lt;/label&gt;
&lt;/div&gt;
&lt;/li&gt;


&lt;div class&#x3D;&quot;ms-RadioButton&quot;&gt;
&lt;li class&#x3D;&quot;ms-RadioButton&quot;&gt;
&lt;input tabindex&#x3D;&quot;-1&quot; type&#x3D;&quot;radio&quot; class&#x3D;&quot;ms-RadioButton-input&quot;&gt;
&lt;label role&#x3D;&quot;radio&quot;
class&#x3D;&quot;ms-RadioButton-field &quot;
Expand All @@ -83,7 +83,7 @@ Used to indicate a single choice from multiple options.
&gt;
&lt;span class&#x3D;&quot;ms-Label&quot;&gt;Option 4&lt;/span&gt;
&lt;/label&gt;
&lt;/div&gt;
&lt;/li&gt;
&lt;/ul&gt;
&lt;/div&gt;
</code>
Expand Down
1 change: 1 addition & 0 deletions src/components/ChoiceFieldGroup/ChoiceFieldGroup.scss
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@
.ms-ChoiceFieldGroup-list {
padding: 0;
margin: 0;
list-style: none;
}
}