This repository has been archived by the owner on Mar 26, 2019. It is now read-only.
Fix TypeError when event.target is HTMLDocument #316
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you put a ContextualMenu and a DatePicker on the same page; and click inside the DatePicker; you get an unhandled TypeError.
ContextualMenu _onDocumentClick asserts event.target as HTMLElement. However, when you click in the DatePicker's textfield; the DatePicker will fire an event with the document object as a target. (Jquery.DatePicker.ts line 112)
Since the document object is an HTMLDocument, not an HTMLElement, classList ends up as undefined. Hence you get the TypeError when trying to access classList.contains.
Attachment: A minimal HTML page to reproduce the problem. (Rename the file extension)
contextualmenu-datecontrol-bug.html.txt