This repository has been archived by the owner on Mar 26, 2019. It is now read-only.
Checkbox not working within a Pivot #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into a problem where input type="checkbox" wasn´t working inside of a Pivot because of the onClick eventListener. Not sure if this is the best way to solve the problem but it does seems to work fine for me.
|
Hi @ericivarsson, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
Approved. Thanks @ericivarsson. I was able to repro the issue and keeping the onClick listener contained to ms-Pivot-links fixes the issue. |
|
Approved |
|
@ericivarsson this PR is unable to be merge because the base branch is out of date. Can you merge the latest changes from master into your fork? |
|
@wdo3650 Sorry for the delay, I´ve updated the branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a problem where input type="checkbox" wasn´t working inside of a Pivot because of the onClick eventListener.
Not sure if this is the best way to solve the problem but it does seem to work fine for me.