Skip to content

Commit 400040a

Browse files
authored
fix(bundle-size): Disable failing tests on CI (#19020)
* fix(bundle-size): Disable failing tests on CI * Change files * fix test with await
1 parent a264d46 commit 400040a

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "none",
3+
"comment": "Disable readConfig tests to unblock CI",
4+
"packageName": "@fluentui/bundle-size",
5+
"email": "lingfan.gao@microsoft.com",
6+
"dependentChangeType": "none"
7+
}

packages/bundle-size/src/utils/readConfig.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ describe('prepareFixture', () => {
3232
});
3333

3434
it('should read config from package', async () => {
35-
setup(`module.exports = { webpack: (config) => { config.foo = 'bar'; return config; } }`);
35+
await setup(`module.exports = { webpack: (config) => { config.foo = 'bar'; return config; } }`);
3636

3737
const config = await readConfig();
3838

@@ -48,9 +48,9 @@ describe('prepareFixture', () => {
4848
it('should cache config', async () => {
4949
process.env.NODE_ENV = 'nottest';
5050

51-
setup(`module.exports = { webpack: (config) => config }`);
51+
await setup(`module.exports = { webpack: (config) => config }`);
5252
const firstConfig = await readConfig();
53-
setup(`module.exports = { webpack: (config) => { config.foo = 'bar'; return config; } }`);
53+
await setup(`module.exports = { webpack: (config) => { config.foo = 'bar'; return config; } }`);
5454
const config = await readConfig();
5555

5656
expect(firstConfig).toBe(config);
@@ -60,7 +60,7 @@ describe('prepareFixture', () => {
6060
});
6161

6262
it.each([1, 2, 3])('should cache config for %i layers of nesting', async nesting => {
63-
setup(`module.exports = { webpack: (config) => { config.foo = 'bar'; return config; } }`, nesting);
63+
await setup(`module.exports = { webpack: (config) => { config.foo = 'bar'; return config; } }`, nesting);
6464
const config = await readConfig();
6565

6666
expect(config.webpack({})).toEqual({ foo: 'bar' });

0 commit comments

Comments
 (0)