Skip to content

fix(bundle-size): Fix failing tests on CI #19020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 20, 2021
Merged

fix(bundle-size): Fix failing tests on CI #19020

merged 3 commits into from
Jul 20, 2021

Conversation

@ling1726
Copy link
Contributor

@ling1726 ling1726 commented Jul 20, 2021 •
edited
Loading

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

await was not being called for the setup function

Focus areas to test

(optional)

@ling1726 ling1726 requested a review from a team as a code owner July 20, 2021 13:08
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 20, 2021 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against a264d460644ea8e7adce4364d843412909d0c974

@ling1726 ling1726 enabled auto-merge (squash) July 20, 2021 13:17
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 20, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f9ecd49:

Sandbox Source
Fluent UI React Starter Configuration

@size-auditor
Copy link

size-auditor bot commented Jul 20, 2021 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: a264d460644ea8e7adce4364d843412909d0c974 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 20, 2021 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 799 797 5000
BaseButton mount 932 895 5000
Breadcrumb mount 2635 2656 1000
ButtonNext mount 503 529 5000
Checkbox mount 1474 1493 5000
CheckboxBase mount 1313 1329 5000
ChoiceGroup mount 4684 4686 5000
ComboBox mount 964 981 1000
CommandBar mount 10099 10107 1000
ContextualMenu mount 6300 6269 1000
DefaultButton mount 1131 1114 5000
DetailsRow mount 3772 3693 5000
DetailsRowFast mount 3720 3645 5000
DetailsRowNoStyles mount 3555 3476 5000
Dialog mount 2106 2150 1000
DocumentCardTitle mount 137 137 1000
Dropdown mount 3250 3192 5000
FluentProviderNext mount 7354 7408 5000
FocusTrapZone mount 1816 1768 5000
FocusZone mount 1801 1821 5000
IconButton mount 1712 1720 5000
Label mount 325 323 5000
Layer mount 1760 1772 5000
Link mount 480 449 5000
MakeStyles mount 1853 1810 50000
MenuButton mount 1486 1450 5000
MessageBar mount 2001 2044 5000
Nav mount 3248 3239 1000
OverflowSet mount 1057 1033 5000
Panel mount 2083 2053 1000
Persona mount 839 840 1000
Pivot mount 1392 1410 1000
PrimaryButton mount 1257 1283 5000
Rating mount 7578 7660 5000
SearchBox mount 1359 1383 5000
Shimmer mount 2467 2459 5000
Slider mount 1938 1950 5000
SpinButton mount 5028 4955 5000
Spinner mount 406 409 5000
SplitButton mount 3147 3131 5000
Stack mount 481 478 5000
StackWithIntrinsicChildren mount 1519 1536 5000
StackWithTextChildren mount 4496 4462 5000
SwatchColorPicker mount 10201 10131 5000
Tabs mount 1422 1380 1000
TagPicker mount 2480 2455 5000
TeachingBubble mount 11870 11909 5000
Text mount 413 420 5000
TextField mount 1358 1379 5000
ThemeProvider mount 1188 1190 5000
ThemeProvider virtual-rerender 600 589 5000
Toggle mount 819 791 5000
buttonNative mount 106 115 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 210 184 1.14:1
RefMinimalPerf.default 261 228 1.14:1
ReactionMinimalPerf.default 406 368 1.1:1
TreeWith60ListItems.default 176 163 1.08:1
LoaderMinimalPerf.default 720 673 1.07:1
TextAreaMinimalPerf.default 508 474 1.07:1
SkeletonMinimalPerf.default 359 340 1.06:1
AccordionMinimalPerf.default 144 137 1.05:1
FormMinimalPerf.default 394 379 1.04:1
ImageMinimalPerf.default 374 361 1.04:1
IconMinimalPerf.default 603 581 1.04:1
AttachmentMinimalPerf.default 150 145 1.03:1
DividerMinimalPerf.default 358 347 1.03:1
HeaderMinimalPerf.default 359 347 1.03:1
HeaderSlotsPerf.default 771 752 1.03:1
ProviderMinimalPerf.default 988 958 1.03:1
TableManyItemsPerf.default 1913 1854 1.03:1
ButtonMinimalPerf.default 163 160 1.02:1
CardMinimalPerf.default 550 538 1.02:1
LayoutMinimalPerf.default 365 358 1.02:1
MenuButtonMinimalPerf.default 1640 1611 1.02:1
RadioGroupMinimalPerf.default 442 433 1.02:1
SegmentMinimalPerf.default 350 343 1.02:1
ButtonSlotsPerf.default 536 532 1.01:1
ChatMinimalPerf.default 654 648 1.01:1
CheckboxMinimalPerf.default 2769 2744 1.01:1
DatepickerMinimalPerf.default 5421 5378 1.01:1
GridMinimalPerf.default 336 333 1.01:1
LabelMinimalPerf.default 385 380 1.01:1
PortalMinimalPerf.default 178 177 1.01:1
ProviderMergeThemesPerf.default 1681 1672 1.01:1
TextMinimalPerf.default 340 338 1.01:1
CustomToolbarPrototype.default 3816 3789 1.01:1
TreeMinimalPerf.default 791 784 1.01:1
AnimationMinimalPerf.default 415 417 1:1
DropdownManyItemsPerf.default 675 672 1:1
InputMinimalPerf.default 1258 1255 1:1
ItemLayoutMinimalPerf.default 1211 1214 1:1
ListMinimalPerf.default 507 508 1:1
ListWith60ListItems.default 636 635 1:1
RosterPerf.default 1169 1168 1:1
PopupMinimalPerf.default 597 596 1:1
SliderMinimalPerf.default 1549 1551 1:1
StatusMinimalPerf.default 667 666 1:1
VideoMinimalPerf.default 610 609 1:1
DialogMinimalPerf.default 741 750 0.99:1
DropdownMinimalPerf.default 3096 3121 0.99:1
ListCommonPerf.default 616 623 0.99:1
SplitButtonMinimalPerf.default 3724 3752 0.99:1
TableMinimalPerf.default 395 397 0.99:1
TooltipMinimalPerf.default 991 1005 0.99:1
AttachmentSlotsPerf.default 1071 1089 0.98:1
ButtonOverridesMissPerf.default 1666 1707 0.98:1
ChatWithPopoverPerf.default 349 356 0.98:1
EmbedMinimalPerf.default 4064 4131 0.98:1
FlexMinimalPerf.default 281 287 0.98:1
MenuMinimalPerf.default 822 842 0.98:1
AlertMinimalPerf.default 262 269 0.97:1
ListNestedPerf.default 546 561 0.97:1
ChatDuplicateMessagesPerf.default 280 293 0.96:1
ToolbarMinimalPerf.default 917 952 0.96:1
CarouselMinimalPerf.default 447 471 0.95:1
BoxMinimalPerf.default 337 357 0.94:1

@ling1726 ling1726 disabled auto-merge July 20, 2021 13:42
@ling1726 ling1726 enabled auto-merge (squash) July 20, 2021 13:43
@ling1726 ling1726 changed the title fix(bundle-size): Disable failing tests on CI fix(bundle-size): Fix failing tests on CI Jul 20, 2021
@ling1726 ling1726 merged commit 400040a into microsoft:master Jul 20, 2021
PeterDraex pushed a commit to PeterDraex/fluentui that referenced this pull request Aug 6, 2021
@ling1726 @PeterDraex
fix(bundle-size): Disable failing tests on CI (microsoft#19020)
81948a4 
* fix(bundle-size): Disable failing tests on CI

* Change files

* fix test with await
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@layershifter layershifter layershifter approved these changes

+1 more reviewer

@theerebuss theerebuss theerebuss approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ling1726 ling1726

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ling1726 @fabricteam @layershifter @theerebuss