Skip to content

fix(bundle-size): Fix failing tests on CI #19020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 20, 2021
Merged

fix(bundle-size): Fix failing tests on CI #19020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e388aa7
fix(bundle-size): Disable failing tests on CI
ling1726 Jul 20, 2021
2b5fd5e
Change files
ling1726 Jul 20, 2021
f9ecd49
fix test with await
ling1726 Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-bundle-size-c77217e2-b073-4e13-8b8c-f1f5be620f20.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "Disable readConfig tests to unblock CI",
"packageName": "@fluentui/bundle-size",
"email": "lingfan.gao@microsoft.com",
"dependentChangeType": "none"
}
8 changes: 4 additions & 4 deletions packages/bundle-size/src/utils/readConfig.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ describe('prepareFixture', () => {
});

it('should read config from package', async () => {
setup(`module.exports = { webpack: (config) => { config.foo = 'bar'; return config; } }`);
await setup(`module.exports = { webpack: (config) => { config.foo = 'bar'; return config; } }`);

const config = await readConfig();

Expand All @@ -48,9 +48,9 @@ describe('prepareFixture', () => {
it('should cache config', async () => {
process.env.NODE_ENV = 'nottest';

setup(`module.exports = { webpack: (config) => config }`);
await setup(`module.exports = { webpack: (config) => config }`);
const firstConfig = await readConfig();
setup(`module.exports = { webpack: (config) => { config.foo = 'bar'; return config; } }`);
await setup(`module.exports = { webpack: (config) => { config.foo = 'bar'; return config; } }`);
const config = await readConfig();

expect(firstConfig).toBe(config);
Expand All @@ -60,7 +60,7 @@ describe('prepareFixture', () => {
});

it.each([1, 2, 3])('should cache config for %i layers of nesting', async nesting => {
setup(`module.exports = { webpack: (config) => { config.foo = 'bar'; return config; } }`, nesting);
await setup(`module.exports = { webpack: (config) => { config.foo = 'bar'; return config; } }`, nesting);
const config = await readConfig();

expect(config.webpack({})).toEqual({ foo: 'bar' });
Expand Down