Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More String changes #767

Merged
merged 9 commits into from
May 10, 2021
Merged

More String changes #767

merged 9 commits into from
May 10, 2021

Conversation

zhenyasav
Copy link
Contributor

  • updated message extensions

@zhenyasav zhenyasav marked this pull request as draft May 8, 2021 02:54
@zhenyasav zhenyasav mentioned this pull request May 8, 2021
Merged
4 tasks
@blackchoey
Copy link
Contributor

The sdk part looks fine to me, also involve @YitongFeng-git to help take a look at the template part.

@zhenyasav zhenyasav marked this pull request as ready for review May 10, 2021 00:38
@zhenyasav
Copy link
Contributor Author

going to merge this based on Chaoyi's review above, it's making other PRs from Yitong harder to read right now

@zhenyasav zhenyasav merged commit 400f35f into main May 10, 2021
@zhenyasav zhenyasav deleted the zhenya/review2 branch May 10, 2021 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackchoey blackchoey Awaiting requested review from blackchoey

@dilin-MS dilin-MS Awaiting requested review from dilin-MS

@SLdragon SLdragon Awaiting requested review from SLdragon

@tecton tecton Awaiting requested review from tecton

@wenytang-ms wenytang-ms Awaiting requested review from wenytang-ms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhenyasav @blackchoey