Skip to content

Commit

Permalink
NBT Parse Error Usage
Browse files Browse the repository at this point in the history
Tried out bringing over the experimental new error object I made over in NBTify, which allows you to find out where the parsing stage failed, as well as access the data that was read thus far, and to be able to easily know where the reading process left off, allowing you to continue reading afterwards later on. This helps a lot with the `readNBTList()` implementation, because chunks of NBT data are placed adjacent to each other, and I had to do some error message-reading magic logic to get that info. This simplifies this concept, by plainly providing this error to the user.

I'm not sure how I want this to look yet, I think it is a great concept to have though! It's like how `DOMException` works in conjunction with when `showOpenFilePicker()` throws, and you can actually get the info about why it threw using that error type. I didn't know that was something you could do, and that was a big find for me!

Git Submodules are extra cool, I wish I had used them for STE with NumText and MenuDrop way back, before I used a bundler or npm. Not sure how submodules work in conjunction with GitHub Pages though. My hope would be that they are cloned when the page is built as well, so definitely something I'll have to look into.

I would have liked to just install the source from GitHub using npm, but it doesn't work with my TS code, because of the `.npmignore` file I have, it excludes the `src` directory. Otherwise, I would like to use that instead, if it did work for that. Too bad there's not a distinction to ignore the `.npmignore` when cloning a specific project. Maybe that is already some flag I don't know about?

Offroaders123/NBTify@388ac02
Offroaders123/NBTify#31
https://git-scm.com/book/en/v2/Git-Tools-Submodules
https://stackoverflow.com/questions/10914022/how-do-i-check-out-a-specific-version-of-a-submodule-using-git-submodule
  • Loading branch information
Offroaders123 committed Feb 3, 2024
1 parent 2efec63 commit 12500d9
Show file tree
Hide file tree
Showing 6 changed files with 490 additions and 15 deletions.
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "NBTify"]
path = NBTify
url = https://github.com/Offroaders123/NBTify.git
1 change: 1 addition & 0 deletions NBTify
Submodule NBTify added at 388ac0
Loading

0 comments on commit 12500d9

Please sign in to comment.