-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax trait bounds for all color types #238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 24d8385Click to view benchmark
|
6f7828e
to
2337cf3
Compare
Benchmark for caeb364Click to view benchmark
|
2337cf3
to
0b212b0
Compare
I just realized I forgot |
Benchmark for 79e4226Click to view benchmark
|
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed all trait bound on color type definitions and made them more relaxed in some places. This should also enable
const fn
in some places! I guess the unfortunate (or fortunate?) effect of this is that it highlighted some shortcomings in the current set if traits. Particularly that theComponent
+FloatComponent
combo doesn't exactly reflect how the type parameters are used and comes with a lot of assumptions. In other words, there's more trait fixing to do than I thought.Breaking Change
Some forced trait bounds were changed in ways that will be breaking. Particularly on
WhitePoint
.