Implement SIMD support and add wide integration
#278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ogeon
changed the title
wide integration
Benchmark for 780844cClick to view benchmark
|
Benchmark for 7787441Click to view benchmark
|
Benchmark for 50c6381Click to view benchmark
|
|
It's a bummer that the RGB to HSL and RGB to HSV conversion is so much slower. I'll try with the old one behind type ID checks (i.e. Great Value Specialization) for now and see if it works better. I should see if I can add benchmarks for the SIMD versions before merging this. |
Benchmark for 48c254fClick to view benchmark
|
|
Looks like the performance gain varies from nothing to several times faster, depending on the work. Converting sRGB to linear RGB is even a bit slower on my machine (possibly due to the I don't think I will go through and optimize everything now. Just making sure there's any improvement at all. |
|
The benchmark fails because the |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds initial support for SIMD types in most places. An exception is the
Luvrelated types, where the conversion logic need extra attention. Some of the conversions aren't necessarily optimal but the focus was on making it work at all.Integration with the wide crate has been added behind a feature flag, as a first example. More SIMD crates can be added in the future.
Breaking Change
Some functions that used to return
boolis now returning a mask type. This mask type is stillboolfor regular floats and ints, so this change will mostly affect generic code.GetHuewas also changed to no longer returnOption<T>for SIMD friendliness.