Add the HyAB color difference metric #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@okaneco, you may want to have a look at this, so I don't make too many things up in the documentation. I would appreciate an extra pair of eyes, if you want to/have time. 🙂 |
Benchmark for ce40517Click to view benchmark
|
okaneco
reviewed
May 6, 2023
palette/src/color_difference.rs
Outdated
| //! |-------|------------|----------|-------| | ||
| //! | [`Ciede2000`] | High | High for small differences, lower for large differences | The de-facto standard, but requires complex calculations to compensate for increased errors in certain areas of the CIE L\*a\*b\* (CIELAB) space. | ||
| //! | [`EuclideanDistance`] | Low | Medium to high for perceptually uniform spaces, otherwise low | Can be good enough for perceptually uniform spaces or as a "quick and dirty" check. | ||
| //! | [`HyAb`] | Low | High for large differences, compared to CIEDE2000, for CIE L\*a\*b\* (CIELAB) | Similar to Euclidean distance, but separates lightness and chroma more. Limited to Cartesian spaces with a lightness axis and a chroma plane. |
There was a problem hiding this comment.
I think HyAb is presented as being a "good enough" option even for smaller differences according to the conclusion. It's not as accurate as Ciede2000 for small differences but the performance benefits outweigh the loss of accuracy for general purpose uses.
It is reasonable to conclude that the HyAB formula has the best correlation with visual observations for very large color differences. It has the best performance for the first category and third category of the first dataset. It
also holds up well for smaller color differences and thus is a good candidate formula for image processing and
computer vision applications.
...
So, the HyAB and HyCH could be used for small to large color difference calculation. However, the HyAB has a slightly better performance and the advantage of simpler computation.
In summary, something like
High accuracy for medium to large differences. Less accurate than
Ciede2000for small differences, but still performs well and is much less computationally expensive.
Everything else looks good 🙂
There was a problem hiding this comment.
Ah, yeah, I missed that part. I'll update it! I think I'll also highlight that the WCAG 2.1 contrast only checks lightness. Thanks for having a look and I hope you didn't mind the ping!
There was a problem hiding this comment.
No worries, glad to help.
Good idea on the highlight in the relative contrast notes. I would expand the explanation of computer graphics slightly,
Meant for checking contrast in computer graphics (such as between text and background colors)
There was a problem hiding this comment.
Yeah, that's good to clarify. 👍
Benchmark for f911acfClick to view benchmark
|
Benchmark for 0ce86d9Click to view benchmark
|
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the HyAB color distance metric for
Lab,OklabandLuv. It's primarily only meant for CIELAB, but I figured it may translate well to the other two as well, since they have similar semantics.I have also added a summary of the available difference metrics in the module description. It's not exactly precise or scientific, but may still be helpful.
Closed Issues