use flt() function #35
Conversation
|
|
||
| use palette::{Rgba, Gradient, Mix}; | ||
| use palette::{Rgba, Gradient, Mix, flt}; |
There was a problem hiding this comment.
Oh, I don't think we should make it public...
There was a problem hiding this comment.
I'm not even sure why the function below uses T instead of f32.
There was a problem hiding this comment.
Damn, I was aiming for a no error merge. May be next time :).
There was a problem hiding this comment.
Haha, it was almost flawless 😄 This is why it's nice to have a second pair of eyes that can review ones changes. I don't know if you have considered it, but you are most welcome to review my pull requests, as well. You have full permission to use my own rules and guidelines against me 😉
|
Did you try to apply it in |
|
I missed those. Changes done |
| @@ -22,10 +24,10 @@ impl<C: Mix + Clone> Gradient<C> { | |||
| pub fn new<I: IntoIterator<Item = C>>(colors: I) -> Gradient<C> { | |||
| let mut points: Vec<_> = colors.into_iter().map(|c| (C::Scalar::zero(), c)).collect(); | |||
| assert!(points.len() > 0); | |||
| let step_size = C::Scalar::one() / <C::Scalar as NumCast>::from(max(points.len() - 1, 1) as f64).unwrap(); | |||
| let step_size = C::Scalar::one() / flt::<C::Scalar, _>(max(points.len() - 1, 1) as f64); | |||
There was a problem hiding this comment.
I assumed it wouldn't, but it does work. Made the change.
|
Yup, missed a couple. Everything in this file should be ok now. |
|
Great! It's so nice to read this diff. The new code is so much tidier. I think this was all, so let's run it through the compactor and merge. |
|
...and it's even negative. You managed to shorten the code by one line. |
|
done |
|
Alright, thank you! @homu r+ |
|
📌 Commit eb7b027 has been approved by |
|
⚡ Test exempted - status |
use flt() function Use function flt() to convert constants to trait Float type. Changed all T::from().unwrap() to use this flt() function defined in lib.rs. Makes the code easier to read, especially the formula's. closes #33
Use function flt() to convert constants to trait Float type. Changed all T::from().unwrap() to use this flt() function defined in lib.rs. Makes the code easier to read, especially the formula's.
closes #33