-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add traits for delta E and the improved formulas from Huang et al #355
Conversation
Codecov Report
@@ Coverage Diff @@
## master #355 +/- ##
==========================================
+ Coverage 78.00% 78.11% +0.11%
==========================================
Files 115 115
Lines 19738 19812 +74
Branches 19738 19812 +74
==========================================
+ Hits 15396 15476 +80
+ Misses 4076 4070 -6
Partials 266 266
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
CodSpeed Performance ReportMerging #355 will not alter performanceComparing Summary
Benchmarks breakdown
|
Ok, this is a pickle. The |
0c772bf
to
45e27b2
Compare
45e27b2
to
c0f13d8
Compare
Interesting, those benchmarks run about 10 to 20 times faster on my machine. Either way, it's the relative difference that's actually interesting. |
bors r+ |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Adds the
DeltaE
,ImprovedDeltaE
andImprovedCiede200
traits. The first one represents the "default" or canonical delta E formula for a color space as it was originally specified. If there is no specification for delta E, it's not implemented. It's also not necessarily the best. The other two implement the enhancements described in Power functions improving the performance of color-difference formulas by Huang et al. They are provided as separate traits so the user can choose which one is the most appropriate for their use case.This is the result of me trying to sort out where different formulas come from and prepare for adding a delta E for CAM16-UCS in #342. The recommended formula for CAM16 turns out to be the "improved" one.