Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo about max range of u8 #374

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Fix typo about max range of u8 #374

merged 1 commit into from
Jan 25, 2024

Conversation

MultisampledNight
Copy link
Contributor

Unsigned integer values (u8, u16, u32, etc.) have a range from 0 to their largest representable value. For example 0u8 to 155u8 [...]

However, the largest value of u8 is not 155, it's 255. Chances are it's just been a typo.

No code was changed, only the documentation.

@Ogeon
Copy link
Owner

Ogeon commented Jan 25, 2024

Yes, that's very much a typo. Thanks for spotting it and submitting a fix!

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4c97fb5) 81.46% compared to head (5889047) 81.18%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
- Coverage   81.46%   81.18%   -0.29%     
==========================================
  Files         113      113              
  Lines       18438    17748     -690     
  Branches    18438    17748     -690     
==========================================
- Hits        15021    14409     -612     
+ Misses       3220     3181      -39     
+ Partials      197      158      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 25, 2024

CodSpeed Performance Report

Merging #374 will degrade performances by 20.49%

⚠️ No base runs were found

Falling back to comparing MultisampledNight:fix-typo (5889047) with master (4c97fb5)

Summary

❌ 1 regressions
✅ 44 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master MultisampledNight:fix-typo Change
matrix_inverse 215.6 ns 271.1 ns -20.49%

@Ogeon
Copy link
Owner

Ogeon commented Jan 25, 2024

Ignore those two 😅

@Ogeon Ogeon changed the title docs: fix typo about max range of u8 Fix typo about max range of u8 Jan 25, 2024
@Ogeon Ogeon merged commit 919049c into Ogeon:master Jan 25, 2024
15 of 17 checks passed
@MultisampledNight MultisampledNight deleted the fix-typo branch January 25, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants