Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix angle conversion from f32 to u8 #386

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Conversation

Ogeon
Copy link
Owner

@Ogeon Ogeon commented Mar 31, 2024

This fixes an issue that made angles convert to 0u8 instead of their expected u8 values.

Closed Issues

Copy link

codspeed-hq bot commented Mar 31, 2024

CodSpeed Performance Report

Merging #386 will not alter performance

Comparing issue_385_angle_f32_to_u8 (9ed7fef) with master (bbd6d4b)

Summary

✅ 45 untouched benchmarks

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.01%. Comparing base (bbd6d4b) to head (9ed7fef).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
+ Coverage   81.94%   82.01%   +0.06%     
==========================================
  Files         115      115              
  Lines       18277    18287      +10     
  Branches    18277    18287      +10     
==========================================
+ Hits        14978    14998      +20     
+ Misses       3141     3131      -10     
  Partials      158      158              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ogeon Ogeon changed the title Fix angle conversion from f32 to u8 Fix angle conversion from f32 to u8 Mar 31, 2024
@Ogeon Ogeon merged commit ccc521b into master Mar 31, 2024
17 checks passed
@Ogeon Ogeon deleted the issue_385_angle_f32_to_u8 branch April 27, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Angle Conversion from f32,f64 to u8
1 participant