-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a new system for converting to and from arrays and slices #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
692f5a9
to
091efd4
Compare
0d2fa65
to
31568d9
Compare
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 11, 2018
81: Make a new system for converting to and from arrays and slices r=Ogeon a=Ogeon This should make some interoperability with other systems better, by making it easier to convert buffers and individual pixels to palette colors. This includes * Bit by bit conversion system for colors. * `Rgb` works with `u8` and other integer types. * `Luma` works with `u8` and other integer types, and can also be non-linear. * Implements `AsRef` to convert colors to raw data. * A slight improvement to the hue types. No need to explicitly call `.into()` when setting a hue. Closes #74
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 11, 2018
81: Make a new system for converting to and from arrays and slices r=Ogeon a=Ogeon This should make some interoperability with other systems better, by making it easier to convert buffers and individual pixels to palette colors. This includes * Bit by bit conversion system for colors. * `Rgb` works with `u8` and other integer types. * `Luma` works with `u8` and other integer types, and can also be non-linear. * Implements `AsRef` to convert colors to raw data. * A slight improvement to the hue types. No need to explicitly call `.into()` when setting a hue. Closes #74
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make some interoperability with other systems better, by making it easier to convert buffers and individual pixels to palette colors.
This includes
Rgb
works withu8
and other integer types.Luma
works withu8
and other integer types, and can also be non-linear.AsRef
to convert colors to raw data..into()
when setting a hue.Closes #74