tools: update v8.gyp and node.gypi

until 0f0b31744fc2e4d3ac3811fad5a355822b254408
OhadRau · Jun 28, 2019 · c2ab560 · c2ab560
1 parent b745777
commit c2ab560
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/node.gypi b/node.gypi
@@ -72,6 +72,7 @@
       'dependencies': [
         'tools/v8_gypfiles/v8.gyp:v8_snapshot',
         'tools/v8_gypfiles/v8.gyp:v8_libplatform',
+        'tools/v8_gypfiles/v8.gyp:v8_crash_keys',
       ],
     }],
     [ 'node_use_v8_platform=="true"', {

diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp
@@ -65,6 +65,7 @@
             '<(torque_output_root)/torque-generated/exported-macros-assembler-tq.cc',
             '<(torque_output_root)/torque-generated/exported-macros-assembler-tq.h',
             '<(torque_output_root)/torque-generated/csa-types-tq.h',
+            '<(torque_output_root)/torque-generated/instance-types-tq.h',
             '<@(torque_outputs)',
           ],
           'action': [
@@ -743,6 +744,16 @@
         }],
       ],
     },  # v8_base_without_compiler
+    {
+      'target_name': 'v8_crash_keys',
+      'type': 'static_library',
+      'sources': ['<(V8_ROOT)/src/diagnostics/crash-key-noop.cc'], # This is fine since we don't build with Chromium
+      'conditions': [
+        ['want_separate_host_toolset', {
+          'toolsets': ['host', 'target'],
+        }],
+      ],
+    },  # v8_crash_keys
     {
       'target_name': 'v8_base',
       'type': 'none',
@@ -754,6 +765,7 @@
       'dependencies': [
         'v8_base_without_compiler',
         'v8_compiler',
+        'v8_crash_keys'
       ],
     },  # v8_base
     {