Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for Nexo #497

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Adds support for Nexo #497

wants to merge 6 commits into from

Conversation

FireML
Copy link
Contributor

@FireML FireML commented Nov 26, 2024

Description

Adds support for Nexo, a new custom items plugin created by the old maintainer of Oraxen.


What has changed?

  • Adds a J21 addon module
  • Adds the Nexo addon
  • Reworks the EMFPlugin interface into an abstract class to make things look cleaner Moved to Add PlatformAdapters #506
  • Fixes the relocation of BoostedYAML Moved to Economy Rework #502

Related Issues

None


Checklist

  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the documentation as needed.
  • I have added any labels that fit this PR.

@FireML
Copy link
Contributor Author

FireML commented Nov 26, 2024

I cannot test this myself as i do not own Nexo. I'd like if somebody who does can test it before this is merged.

@FireML
Copy link
Contributor Author

FireML commented Nov 26, 2024

I also can't add labels, so i cannot check that box either.

@sarhatabaot
Copy link
Collaborator

I also can't add labels, so i cannot check that box either.

Ah yes, I'll add an action and an updated PR template for that. Sorry about that.

@FireML FireML marked this pull request as draft November 28, 2024 00:21
@FireML
Copy link
Contributor Author

FireML commented Nov 28, 2024

Converted this to a draft until it can be tested. I have to wait for Nexo's source code to be released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants